Snow 1917307 refresh token #1040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pmotacki
changed the base branch from
master
to
SNOW-1979798-client-credentials
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-pmotacki
force-pushed
the
SNOW-1979798-client-credentials
branch
from
9093de5 to
5448f6c
Compare
sfc-gh-pmotacki
changed the base branch from
SNOW-1979798-client-credentials
to
master
sfc-gh-pmotacki
changed the base branch from
master
to
SNOW-1979798-client-credentials
sfc-gh-pmotacki
force-pushed
the
SNOW-1917307-refresh-token
branch
from
dbc19a0 to
ea77ff9
Compare
| token = await requestToken(as, tokenUrl, client, clientAuth, params, redirectUri, codeVerifier); | ||
|
|
||
| //verify that there is access token in the cache | ||
| const accessTokenFromCache = await GlobalConfig.getCredentialManager().read(accessTokenKey); |
There was a problem hiding this comment.
perhaps extract credentialManager to a variable/member?
| globalThis.crypto ??= require('node:crypto').webcrypto; | ||
| await this.loadOauth4webapi(); // import module using the dynamic import | ||
| // const codeChallengeMethod = 'S256'; | ||
| const as = { issuer: 'UNKNOWN' }; |
There was a problem hiding this comment.
comment why this is needed
| //cache refresh token | ||
| Logger.getInstance().debug( | ||
| `Received new OAuth refresh token from: Host: ${tokenUrl.host} Path: ${tokenUrl.pathname}`); | ||
| await GlobalConfig.getCredentialManager().remove(refreshTokenKey); |
There was a problem hiding this comment.
do we have to remove it first? Won't it get replaced?
There was a problem hiding this comment.
Assuming that underneath there is a map type. I'm a little afraid about custom CacheManager implementation but it looks logical that cache could protect before containing rows with duplicated keys.
| @@ -4,6 +4,7 @@ code.INCORRECT_USERNAME_PASSWORD = '390100'; | |||
| code.SESSION_TOKEN_INVALID = '390104'; | |||
| code.GONE_SESSION = '390111'; | |||
| code.SESSION_TOKEN_EXPIRED = '390112'; | |||
| code.OAUTH_TOKEN_EXPIRED = '390318'; | |||
There was a problem hiding this comment.
in JDBC I also handle scenario for this code: OAUTH_ACCESS_TOKEN_INVALID_GS_CODE = 390303;
sfc-gh-pmotacki
force-pushed
the
SNOW-1917307-refresh-token
branch
2 times, most recently
from
53f6d88 to
235d87b
Compare
sfc-gh-pmotacki
changed the base branch from
SNOW-1979798-client-credentials
to
master
sfc-gh-pmotacki
force-pushed
the
SNOW-1917307-refresh-token
branch
from
598ce2e to
6153e48
Compare
sfc-gh-pmotacki
force-pushed
the
SNOW-1917307-refresh-token
branch
from
22dcb2c to
4d9fafe
Compare
sfc-gh-pmotacki
changed the base branch from
master
to
SNOW-1979798-client-credentials
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)