SNOW-2187756 - Next Gen Numbers - DECFLOAT support for Libsfc #958
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
==========================================
+ Coverage 79.80% 80.04% +0.24%
==========================================
Files 129 129
Lines 11111 11227 +116
==========================================
+ Hits 8867 8987 +120
+ Misses 2244 2240 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpp/lib/ArrowChunkIterator.cpp
Outdated
| m_columns[colIdx].arrowStructArray->field(0) | ||
| ); | ||
|
|
||
| std::vector<uint8_t> bec(value, value + len); |
There was a problem hiding this comment.
what bec stands for? big endian code?
There was a problem hiding this comment.
I used the same variable name before refactoring. I changed this to 'rawBytes'.
lib/results.c
Outdated
| break; | ||
| // treat any unknown type as string impossible to hit default though. | ||
| case SF_DB_TYPE_TEXT: | ||
| case SF_DB_TYPE_DECFLOAT: |
There was a problem hiding this comment.
Not sure if it's reasonable to have default_size of decfloat set to max_varchar_size (currently 128M). Maybe have a const specifically for decfloat? Consider the precision of 38 and the max exponent of 16384, I think the length around 50 would be enough.
There was a problem hiding this comment.
Move to a different case and set the default size to 50.
No description provided.