Skip to content

chore: 점검 종료 시간 수정 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nijuy merged 1 commit into from
Feb 9, 2026
Merged

chore: 점검 종료 시간 수정 #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/constants/maintenance.constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const MAINTENANCE_START = new Date('2026-02-09T20:30:00+09:00');
export const MAINTENANCE_END = new Date('2026-02-09T23:59:00+09:00');
export const MAINTENANCE_END = new Date('2026-02-09T21:00:00+09:00');
Comment on lines 1 to +2
Copy link

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

점검 시간을 상수로 하드코딩하면 점검 일정을 변경할 때마다 코드를 수정하고 새로 배포해야 합니다. 이는 실수를 유발할 수 있고 유연성이 떨어집니다.

향후 유지보수성을 높이기 위해, 점검 시작 및 종료 시간을 원격 구성(예: API 서버에서 받아오거나, 환경 변수로 주입)에서 가져오는 것을 고려해 보세요. 이렇게 하면 코드 변경 및 배포 없이 점검 일정을 동적으로 관리할 수 있습니다.


export const isInMaintenance = (now = new Date()) => {
return now >= MAINTENANCE_START && now <= MAINTENANCE_END;
Expand Down
Loading