Service sdk json #1367
Merged
Service sdk json #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 24, 2025 15:17
…hy-kotlin into server-sdk-main # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…n into service-sdk-serde # Conflicts: # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/KotlinDependency.kt # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/RuntimeTypes.kt # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/service/ServiceStubGenerator.kt
…ntime rather than compile
luigi617
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 2 commits
August 6, 2025 08:17
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0marperez
reviewed
Aug 12, 2025
| ) | ||
| .write("var response: Any") | ||
| .write("var response: #T = $defaultResponse", serializerResultSymbol) |
There was a problem hiding this comment.
Why are we sending default responses now?
There was a problem hiding this comment.
In renderSerializeHttpBody, if the output shape does not have a body, response will not be set, which causes an error indicating that response must be initialized.
...lin/software/amazon/smithy/kotlin/codegen/rendering/protocol/HttpBindingProtocolGenerator.kt
Outdated
Show resolved
Hide resolved
| KotlinTypes.Text.encodeToByteArray, | ||
| ) | ||
| if (ctx.settings.build.generateServiceProject) { | ||
| writer.write("response = input.#L.value.toString()", memberName) |
There was a problem hiding this comment.
Should this be int since it's an INT_ENUM?
There was a problem hiding this comment.
In serialization, JSON protocol will return a string as the response body. So, we need to convert everything in String
tests/codegen/service-codegen-tests/src/test/kotlin/com/test/CborServiceTest.kt
Show resolved
Hide resolved
tests/codegen/service-codegen-tests/src/test/kotlin/com/test/utils.kt
Outdated
Show resolved
Hide resolved
...lin/software/amazon/smithy/kotlin/codegen/rendering/protocol/HttpBindingProtocolGenerator.kt
Outdated
Show resolved
Hide resolved
tests/codegen/service-codegen-tests/model/service-json-test.smithy
Outdated
Show resolved
Hide resolved
Affected ArtifactsChanged in size
|
0marperez
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.