Skip to content

Conversation

@Mornix
Copy link
Collaborator

@Mornix Mornix commented Jun 20, 2018

Unlikely changes for gamephys SRS for #100.
screen shot 2018-06-20 at 4 00 38 pm

@Mornix Mornix requested a review from smiths June 20, 2018 20:03
@smiths
Copy link
Owner

smiths commented Jun 20, 2018

I like UC1, but I don't think we need UC2. Although the document is written for 2D, the equations look very similar for 3D physics. If we wrote things just a little more abstractly, changing from 2D to 3D could be considered as a likely change.

@Mornix
Copy link
Collaborator Author

Mornix commented Jun 20, 2018

screen shot 2018-06-20 at 5 07 55 pm

@smiths
Copy link
Owner

smiths commented Jun 26, 2018

Sounds good, but I suggest that you remove the introduction sentence. That is, remove "If changes were made ...". It isn't just the algorithm that will change. The theory changes, data structures may change, etc. The heading of the section can be the introduction. So you can go right into the list.

@samm82
Copy link
Collaborator

samm82 commented Aug 8, 2018

@Mornix this branch has conflicts with master

@Mornix
Copy link
Collaborator Author

Mornix commented Aug 8, 2018

These PR’s slipped my mind. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants