fix: show error message when tool list gets invalid connection name#681
Merged
fix: show error message when tool list gets invalid connection name#681
Conversation
When running `smithery tool list <name>` with a typo (e.g. betterstak instead of betterstack), the CLI silently showed only a dimmed tip with no indication that the connection name was invalid. The error message existed only in the JSON payload and was ignored in text mode. Now display a prominent red error message in text mode when getConnection() fails, matching the error handling pattern used elsewhere in the codebase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's added in this PR?
Added a prominent red error message in text mode when
smithery tool list <name>is called with a non-existent connection ID. Previously, the error only existed in the JSON payload and was ignored in text mode, resulting in a silent failure with just a dimmed tip.Now when a user misspells a connection name (e.g.,
betterstakinstead ofbetterstack), they see:What's the issues or discussion related to this PR?
Previous behavior: Running
smithery tool list betterstak(a typo) silently displayed only the dimmed tip "smithery mcp list - List all connections" with no indication the connection name was invalid.New behavior: A clear red error message tells the user the connection wasn't found, making it obvious they need to check the connection name or list available connections.
This matches the existing error handling pattern used elsewhere in the codebase (e.g.,
tool.ts,get.ts, event commands).