fix(happy-app): handle blank lines and empty cells in markdown table parser#730
Open
Yoowatney wants to merge 1 commit intoslopus:mainfrom
Open
fix(happy-app): handle blank lines and empty cells in markdown table parser#730Yoowatney wants to merge 1 commit intoslopus:mainfrom
Yoowatney wants to merge 1 commit intoslopus:mainfrom
Conversation
…parser LLMs often output markdown tables with blank lines between rows, which caused the table parser to stop collecting lines and render them as raw text. Also fix cell parsing to preserve interior empty cells instead of filtering them out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #506
Two bugs in the markdown table parser:
\n\nbetween rows. The parser stopped collecting at the first blank line, rendering each row as raw text.filter(cell => cell.length > 0)removed interior empty cells (e.g.| | Header1 | Header2 |lost the empty first column), causing column misalignment.Changes
parseTablesplitTableRowhelper that strips only leading/trailing pipe artifacts while preserving interior empty cellsTest plan