Skip to content

feat(app): add workspace file browser to session files screen #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seibe wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(app): add workspace file browser to session files screen #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a69c876
feat(app): add workspace file browser to session files screen
seibe Feb 20, 2026
e1106fa
fix(app): use UTF-8 safe URL-safe base64 for file path encoding
seibe Feb 20, 2026
66f7cb6
fix(app): properly decode UTF-8 multi-byte characters in file viewer
seibe Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 71 additions & 22 deletions packages/happy-app/sources/app/(app)/session/[id]/file.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { useUnistyles, StyleSheet } from 'react-native-unistyles';
import { layout } from '@/components/layout';
import { t } from '@/text';
import { FileIcon } from '@/components/FileIcon';
import { base64ToUtf8 } from '@/utils/stringUtils';

interface FileContent {
content: string;
Expand Down Expand Up @@ -76,12 +77,16 @@ export default function FileScreen() {
const encodedPath = searchParams.path as string;
let filePath = '';

// Decode base64 path with error handling
// Decode base64 path with error handling (UTF-8 safe, with legacy btoa fallback)
try {
filePath = encodedPath ? atob(encodedPath) : '';
} catch (error) {
console.error('Failed to decode file path:', error);
filePath = encodedPath || ''; // Fallback to original path if decoding fails
filePath = encodedPath ? base64ToUtf8(encodedPath) : '';
} catch {
// Fallback to plain atob for legacy paths encoded before UTF-8 migration
try {
filePath = encodedPath ? atob(encodedPath) : '';
} catch {
filePath = encodedPath || '';
}
}

const [fileContent, setFileContent] = React.useState<FileContent | null>(null);
Expand Down Expand Up @@ -213,32 +218,76 @@ export default function FileScreen() {
const response = await sessionReadFile(sessionId, filePath);

if (!isCancelled) {
if (response.success && response.content) {
// Decode base64 content to UTF-8 string
let decodedContent: string;
if (response.success && response.content !== undefined) {
// Decode base64 content to raw bytes
let binaryString: string;
try {
decodedContent = atob(response.content);
} catch (decodeError) {
// If base64 decode fails, treat as binary
binaryString = atob(response.content);
} catch {
setFileContent({
content: '',
encoding: 'base64',
isBinary: true
});
return;
}

// Check if content contains binary data (null bytes or too many non-printable chars)
const hasNullBytes = decodedContent.includes('\0');
const nonPrintableCount = decodedContent.split('').filter(char => {
const code = char.charCodeAt(0);
return code < 32 && code !== 9 && code !== 10 && code !== 13; // Allow tab, LF, CR
}).length;
const isBinary = hasNullBytes || (nonPrintableCount / decodedContent.length > 0.1);


// Handle empty files
const len = binaryString.length;
if (len === 0) {
setFileContent({
content: '',
encoding: 'utf8',
isBinary: false
});
return;
}

// Check for binary data using a loop (avoids split/filter allocation)
let nonPrintableCount = 0;
let hasNullBytes = false;
for (let i = 0; i < len; i++) {
const code = binaryString.charCodeAt(i);
if (code === 0) {
hasNullBytes = true;
break;
}
if (code < 32 && code !== 9 && code !== 10 && code !== 13) {
nonPrintableCount++;
}
}

let isBinary = hasNullBytes || (nonPrintableCount / len > 0.1);
let textContent = '';
let encoding: 'utf8' | 'base64' = isBinary ? 'base64' : 'utf8';

if (!isBinary) {
try {
const bytes = new Uint8Array(len);
for (let i = 0; i < len; i++) {
bytes[i] = binaryString.charCodeAt(i);
}

if (typeof TextDecoder !== 'undefined') {
textContent = new TextDecoder('utf-8', { fatal: true }).decode(bytes);
} else {
const encoded = new Array(len);
for (let i = 0; i < len; i++) {
encoded[i] = '%' + bytes[i].toString(16).padStart(2, '0');
}
textContent = decodeURIComponent(encoded.join(''));
}
} catch {
// Invalid UTF-8: treat as binary
isBinary = true;
encoding = 'base64';
textContent = '';
}
}

setFileContent({
content: isBinary ? '' : decodedContent,
encoding: 'utf8',
content: textContent,
encoding,
isBinary
});
} else {
Expand Down
Loading