Skip to content

Comments

fix: quote CLI path in tmux command to handle spaces#698

Open
davidrimshnick wants to merge 1 commit intoslopus:mainfrom
davidrimshnick:fix/spaces-in-project-path
Open

fix: quote CLI path in tmux command to handle spaces#698
davidrimshnick wants to merge 1 commit intoslopus:mainfrom
davidrimshnick:fix/spaces-in-project-path

Conversation

@davidrimshnick
Copy link

Summary

  • Quotes the CLI entrypoint path (cliPath) in the tmux spawn command string to prevent shell word-splitting when the project path contains spaces
  • e.g. /home/user/My Projects/happy-cli/dist/index.mjs was being split at the space

Fixes #667

Test plan

  • Added 4 unit tests for command construction with various path patterns
  • Verify daemon can spawn sessions in directories with spaces in their paths

🤖 Generated with Claude Code

@davidrimshnick davidrimshnick force-pushed the fix/spaces-in-project-path branch from 5b8dab5 to 99876bf Compare February 21, 2026 19:12
The tmux spawn command interpolated the CLI entrypoint path without
shell quoting, causing failures when the project path contains spaces.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@davidrimshnick davidrimshnick force-pushed the fix/spaces-in-project-path branch from 99876bf to db3dc0b Compare February 21, 2026 19:16
@davidrimshnick
Copy link
Author

Merge note: This PR modifies the same fullCommand line in daemon/run.ts (tmux path) as #1 on the fork (feat/resume-session-from-mobile). If both are merged, the second will have a trivial 1-line conflict — just combine the quoting from this PR with the ${resumeFlag} from the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File watcher fails when project path contains spaces

1 participant