fix(happy-app): make sessionKill idempotent when process already exited#692
Open
davidrimshnick wants to merge 1 commit intoslopus:mainfrom
Open
fix(happy-app): make sessionKill idempotent when process already exited#692davidrimshnick wants to merge 1 commit intoslopus:mainfrom
davidrimshnick wants to merge 1 commit intoslopus:mainfrom
Conversation
When archiving a session whose process had already exited, the RPC call to killSession would fail and show "RPC call failed" to the user. Since the user's intent is "stop this session", and it's already stopped, this should be treated as success. The catch block now returns success with "Session already stopped" instead of surfacing the RPC error. Fixes slopus#687 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
killSessionRPC had no recipientsessionKill()catch block to return{ success: true, message: 'Session already stopped' }instead of surfacing the RPC errorFixes #687
Test plan
sessionKillwith mocked apiSocket🤖 Generated with Claude Code