This repository was archived by the owner on Feb 14, 2026. It is now read-only.
fix: Set machines to active when receiving machine-alive events#31
Open
taranasus wants to merge 1 commit intoslopus:mainfrom
Open
fix: Set machines to active when receiving machine-alive events#31taranasus wants to merge 1 commit intoslopus:mainfrom
taranasus wants to merge 1 commit intoslopus:mainfrom
Conversation
The session activity cache was updating lastActiveAt for machines but not setting active: true, unlike the session update logic. This caused machines to never become active after sending machine-alive events, making them invisible in the mobile app's machine list. The session update correctly sets both lastActiveAt and active: true, but the machine update was missing the active flag.
michelhelsdingen
added a commit
to michelhelsdingen/happy-server
that referenced
this pull request
Feb 3, 2026
Machines were created with active: false and never became active despite sending machine-alive events. This caused them to be invisible in the mobile app's machine list (which filters to only show active: true). Fix from PR slopus#31 by @taranasus Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
machine-aliveeventsProblem
The
flushPendingUpdates()method insessionCache.tswas updatinglastActiveAtfor machines but not settingactive: true, unlike the session update logic which correctly sets both.This caused machines to:
active: false(default)machine-aliveeventsactive: truemachines)Fix
Added
active: trueto the machine update data, matching the session update behavior:Testing
Verified the fix by deploying to a self-hosted instance. Machines now correctly appear in the mobile app after sending alive events.