Fix Windows ARM64/ARM64EC NEON detection and MSVC compatibility#264
Open
navvyswethgraphics wants to merge 1 commit into
Open
Fix Windows ARM64/ARM64EC NEON detection and MSVC compatibility#264navvyswethgraphics wants to merge 1 commit into
navvyswethgraphics wants to merge 1 commit into
Conversation
…itialization in cpHastySpace.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Changes
This PR enables clean builds of Chipmunk’s "cpHastySpace.c" on Windows ARM64 and ARM64EC toolchains by fixing NEON guards, avoiding MSVC‑incompatible NEON compound literals, and architecture/compiler checks.
Replaced non‑portable ARM64 checks with aarch64 macros.
Updated vmake() to avoid MSVC‑unsupported NEON compound literals.
Scoped vrev() fallback to compiler (MSVC vs non‑MSVC), avoiding "__builtin_shufflevector" where unsupported.
Replaced {} vector initialization with vdup_n(0.0) for portability.
Applied the corrected NEON guard consistently in the solver path.
Build & test
Notes