Skip to content

✨ enhance selection loading logic to check for bookmarkBriefInfo befo… #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

✨ enhance selection loading logic to check for bookmarkBriefInfo befo… #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/slax-reader-extensions/src/components/Selection/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ export class MarkManager extends Base {
}

getApproxText(range: Range): HighlightRangeInfo | undefined {
if (!range) {
if (!range || range.collapsed || range.toString().trim().length === 0) {
return undefined
}

Expand Down
4 changes: 2 additions & 2 deletions apps/slax-reader-extensions/src/components/SidePanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ watch(
}

loadBriefDetail().then(() => {
loadSelection()
bookmarkBriefInfo.value && loadSelection()
})
}
)
Expand Down Expand Up @@ -211,7 +211,7 @@ props.browser.runtime.onMessage.addListener(
onMounted(() => {
updateBookmarkStatus()
loadBriefDetail().then(() => {
loadSelection()
bookmarkBriefInfo.value && loadSelection()
})

tryGetUserInfo(true).then(res => {
Expand Down
6 changes: 6 additions & 0 deletions apps/slax-reader-extensions/src/entrypoints/content/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ export default defineContentScript({
html{
z-index: 99999999999 !important;
}

@media print {
:host, html {
display: none !important;
}
}
`,
onMount: container => {
const app = createApp(SidePanel, {
Expand Down
Loading