SQL == CSV For YAML Generation - #72
Merged
Merged
Conversation
- SQL now produces identical YAML files to the current method. - PMT Metadata is no longer needed due to Oralce updates. - device.db updated
williamColocho
approved these changes
Aug 19, 2026
williamColocho
left a comment
Collaborator
There was a problem hiding this comment.
No comments. Looks good to me.
kabanaty
approved these changes
Aug 19, 2026
kabanaty
left a comment
Collaborator
There was a problem hiding this comment.
Hi Eloise, this all looks good to me. We'll find out quickly after the summer downtime if the PMT metadata is working correctly but as of now I think it will be fine. Thanks for the hard work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a regression test verifying that the SQL→YAML pipeline produces output equivalent to the existing CSV + meme pipeline, along with the fixes needed to make that comparison hold.
Once this PR is merged,
slac_db.db_to_yaml.get_device()will be able to fully replace YAML files for all devices.