Open
Conversation
|
I think we'd want to see if upstream would accept this before considering merging, not something we'd want to carry as a custom change on our fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mysqlctl initallows many values to be set via cli args, however{{.ServerID}}is not one of them.sites which use vitess should have the ability to set this according to a site policy.
strictly random generation is technically flawed as it could possibly result in a primary and replica with the same server_id.
although VERY low probability, the result would be lost replication events, as described in vitess' own comments at https://github.com/slackhq/vitess/blob/slack-22.0/go/vt/mysqlctl/cmd.go#L30-L48
more internal slack discussion here:
https://slack-pde.slack.com/archives/CLLEUERMK/p1770773133707789