Skip to content
This repository was archived by the owner on Nov 3, 2025. It is now read-only.

check http status code#17

Open
jasonmacgowan wants to merge 1 commit intoslackhq:masterfrom
jasonmacgowan:feature/honor-http-errors
Open

check http status code#17
jasonmacgowan wants to merge 1 commit intoslackhq:masterfrom
jasonmacgowan:feature/honor-http-errors

Conversation

@jasonmacgowan
Copy link

@jasonmacgowan jasonmacgowan commented Sep 12, 2018

Summary

throws errors on http status codes >=400 so the user knows the expected action failed

fixes (kinda) #16

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

@jasonmacgowan
Copy link
Author

This is a start but really we should be more verbose about what actually failed

Also it's possible to do this by setting something like the following"
curl_setopt($ch,CURLOPT_FAILONERROR,true);

Maybe that's the default for some people and they weren't encountering this?

@fyunaz
Copy link
Contributor

fyunaz commented Dec 19, 2018

Hi, thanks for looking at this. Are you able to visit the following URL to sign the CLA? https://cla-assistant.io/slackhq/goSDL?pullRequest=17

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants