This repository was archived by the owner on Nov 3, 2025. It is now read-only.
check http status code#17
Open
jasonmacgowan wants to merge 1 commit intoslackhq:masterfrom
jasonmacgowan:feature/honor-http-errors
Open
check http status code#17jasonmacgowan wants to merge 1 commit intoslackhq:masterfrom jasonmacgowan:feature/honor-http-errors
jasonmacgowan wants to merge 1 commit intoslackhq:masterfrom
jasonmacgowan:feature/honor-http-errors
Conversation
Author
|
This is a start but really we should be more verbose about what actually failed Also it's possible to do this by setting something like the following" Maybe that's the default for some people and they weren't encountering this? |
Contributor
|
Hi, thanks for looking at this. Are you able to visit the following URL to sign the CLA? https://cla-assistant.io/slackhq/goSDL?pullRequest=17 |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throws errors on http status codes >=400 so the user knows the expected action failed
fixes (kinda) #16
Requirements (place an
xin each[ ])