Skip to content

Conversation

@Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 11, 2023

This PR is separated from #1641, as the disabling of the unattended upgrade for AWS is more urgent for the AWS user.

We are now using the cloud-init to disable the unattended-upgrade which holds the lock for apt. The user's sudo apt install locked issue should now be fixed and deterministic.

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test-fm ./examples/using_file_mounts.yaml (which contains the sudo apt install tree in setup)
    • sky launch -c test-fm1 --num-nodes 1 ./examples/using_file_mounts.yaml
    • sky launch -c min immediately log into the VM after provision and run sudo apt install tree
  • All smoke tests: pytest tests/test_smoke.py --aws

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! Some comments.

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! modulo a question on restore exceptions.

@Michaelvll Michaelvll merged commit bbdd5b1 into master May 11, 2023
@Michaelvll Michaelvll deleted the disable-unattended-upgrade-with-cloud-init branch May 11, 2023 18:17
juanmichelini pushed a commit to ICML-25-BenchName-builds-repair/skypilot that referenced this pull request Jul 10, 2025
* disable unattended-upgrade with cloud-init

* remove the unattended upgrade handling

* format

* fix the replacement

* format

* longer wait time

* use underscore

* fix comments

* Add UserData to the older cluster

* Add comment

* remove comment

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants