Skip to content

Conversation

@DanielZhangQD
Copy link
Collaborator

Do not fail the whole k8s infra table if some contexts are not available

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@DanielZhangQD
Copy link
Collaborator Author

  • 3 contexts with two not available:
47f7abf2f2e4131fe0bf934225145764
  • 3 contexts with 1 not available:
abebf44b0e07634072d4559e4df846e9

@DanielZhangQD DanielZhangQD marked this pull request as ready for review November 25, 2025 05:38
@DanielZhangQD DanielZhangQD requested a review from aylei November 25, 2025 05:39
Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DanielZhangQD !

@Michaelvll
Copy link
Collaborator

can we also show the error message for the failed context? For example, when the mouse hover on the 0 row, we should show the reason it fails.

@DanielZhangQD
Copy link
Collaborator Author

can we also show the error message for the failed context? For example, when the mouse hover on the 0 row, we should show the reason it fails.

Now it will show the hint when hovering on the 0 node:
image

@DanielZhangQD DanielZhangQD merged commit e189f3d into master Nov 25, 2025
28 of 32 checks passed
@DanielZhangQD DanielZhangQD deleted the 3858 branch November 25, 2025 06:27
@Michaelvll
Copy link
Collaborator

can we also show the error message for the failed context? For example, when the mouse hover on the 0 row, we should show the reason it fails.

Now it will show the hint when hovering on the 0 node: image

Oh, I mean is it possible to see the actual underlying error, so that it is easier to debug for the reason?

@DanielZhangQD
Copy link
Collaborator Author

can we also show the error message for the failed context? For example, when the mouse hover on the 0 row, we should show the reason it fails.

Now it will show the hint when hovering on the 0 node: image

Oh, I mean is it possible to see the actual underlying error, so that it is easier to debug for the reason?

OK, let me do it in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants