fix(gui): avoid project reload when saving settings on start page - #2943
Merged
Conversation
skylot
approved these changes
Aug 28, 2026
skylot
left a comment
skylot
left a comment
Owner
There was a problem hiding this comment.
Thanks 👍
Although, it might be better to add some kind of flag if project is not yet actually opened and handle such case in reopen method directly, will try to implement that later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid calling
MainWindow.reopen()when saving settings on the start page with no input files, preventing the incorrect “Can't open empty project” dialog.Settings and shortcuts are still applied, and menu accelerators are refreshed immediately. Reload and input-file verification behavior for opened projects remains unchanged.