Skip to content

Feedback on the Node SDK content updates#259

Merged
manny-silva merged 6 commits intojstjoe/2025-11-13/readme-editsfrom
node-sdk-readme-review
Nov 14, 2025
Merged

Feedback on the Node SDK content updates#259
manny-silva merged 6 commits intojstjoe/2025-11-13/readme-editsfrom
node-sdk-readme-review

Conversation

@manny-silva
Copy link
Collaborator

Reviewed all Markdown comments and added suggested edits.

@manny-silva manny-silva requested a review from jstjoe November 14, 2025 18:40
Copy link
Collaborator

@jstjoe jstjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to undo a bunch of it 😬 @manny-silva
And improve some other points (e.g. using real relative links). Curious what you think though.

Copy link
Collaborator

@jstjoe jstjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional note needs context, or to be removed.
One sample link looks wrong.

@manny-silva manny-silva requested a review from jstjoe November 14, 2025 19:25
Copy link
Collaborator

@jstjoe jstjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🖖

@manny-silva manny-silva merged commit c27d78d into jstjoe/2025-11-13/readme-edits Nov 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants