SK-2541 support file upload along with record creation#166
Merged
skyflow-bharti merged 1 commit intomainfrom Feb 9, 2026
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
GoSec Findings: No issues found, Good to merge. |
saileshwar-skyflow
approved these changes
Feb 9, 2026
skyflow-bharti
requested review from
Devesh-Skyflow,
aadarsh-st and
skyflow-himanshu
skyflow-himanshu
approved these changes
Feb 9, 2026
Devesh-Skyflow
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Since skyflow id is optional at the File upload V2 API level, enforcing mandatory validation in the SDK is inconsistent and should be removed.