Skip to content

Conversation

@MahmoudMabrok
Copy link

@MahmoudMabrok MahmoudMabrok commented Oct 21, 2024

Guidelines

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

@skydoves
Copy link
Owner

Thank you for your contribution, @MahmoudMabrok. But the reason of this is, I want to clarify the reason of the CI failures without going to see the details when the build failed.

@MahmoudMabrok
Copy link
Author

MahmoudMabrok commented Oct 21, 2024

@skydoves Thanks for reply. I agree with you.

so we can run all as single job with multiple steps, so we reduce time for 2 extra [checkout, run gradle], also gradle tasks will be cached so lower time.

@MahmoudMabrok MahmoudMabrok changed the title ci: remove spotless and api check as they are done in build step. ci: move spotless and api check to build step. Oct 21, 2024
@MahmoudMabrok
Copy link
Author

MahmoudMabrok commented Oct 26, 2024

could you please check ? @skydoves , if it fine and merged please add label 'hacktoberfest-accepted'

@MahmoudMabrok
Copy link
Author

Please check @skydoves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants