Exposing transformations applied by Cleaner and TableVectorizer - #2122
Exposing transformations applied by Cleaner and TableVectorizer#2122emassoulie wants to merge 26 commits into
Cleaner and TableVectorizer#2122Conversation
|
I've got something going with the transformation lists for both transformers! I feel the TableVectorizer transformations could be equally relevant to expose by raw transformer type ( |
…leaner-and-tablevectorizer-transformations
…leaner-and-tablevectorizer-transformations
…leaner-and-tablevectorizer-transformations
…leaner-and-tablevectorizer-transformations
…r-transformations
rcap107
left a comment
There was a problem hiding this comment.
Thank you very much for the PR @emassoulie ! I did a review of the current material.
In general, I think we're on the right path. I think the main thing to decide is the actual format of the returned string. I think there is too much whitespace, so we may want to investigate how other symbols may make it easier to parse the output.
Other than that, good job!
…leaner-and-tablevectorizer-transformations
rcap107
left a comment
There was a problem hiding this comment.
Thanks a lot for improving the PR!
I think we're getting close to the end, though I think the code can still be improved and simplified in places.
I opened a PR targeting this branch in emassoulie#2 to propose some changes in that direction
Could you also add a mention of list_transformations in the docstring of TableVectorizer and Cleaner? Without printing the entire thing, only the first few lines followed by ... to elide the rest


Closes #1265
Adds a method to the
CleanerandTableVectorizertransformers enabling them to give a human-readable list of the transformations (DropUninformative, ToFloat, ToDatetime) they are set to apply once fitted.