Skip to content

Fix the outdated button name - #138

Open
Foundsheep wants to merge 1 commit into
skills:mainfrom
Foundsheep:fix/outdated-button
Open

Foundsheep wants to merge 1 commit into
skills:mainfrom
Foundsheep:fix/outdated-button

Conversation

@Foundsheep

Copy link
Copy Markdown

Summary

Step 4 uses an outdated name of a button, and is causing a bit of confusion.

Changes

It says to click the Commit suggestion button, but it is actually now Apply suggestion.
This word has changed only.

  • The current step 4 captured
    image
  • The current mismatch captured
    image

Closes: Nothing. In the guideline, this type of simple fix can directly head to PR, so I didn't make any issue.

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@Foundsheep

Copy link
Copy Markdown
Author

Ah, actually the only one issue left open #137, whose title doesn't describe anything related to this subject in fact, is about this change. I can't edit the content above, so I'm just leaving this comment.

@bbarrio2 bbarrio2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<h2 hidden>Game over! Want to play again?! Just click refresh. 🧑‍🚀!</h2>

Comment thread .github/steps/4-step.md

1. In the pull request navigation, select the **Conversation** tab.

1. Scroll down and click the **Commit suggestion** button to open a commit message form.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Scroll down and click the **Commit suggestion** button to open a commit message form.
<h2 hidden>Game over! Want to play again?! Just click refresh. 🧑‍🚀!</h2>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbarrio2 I think you got the wrong place to do your exercise. You should do that on your own repository

@BeckhamX457

Copy link
Copy Markdown

I created the branch, pulled it, and did the steps.

@mhabdullaAe mhabdullaAe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Abdulmajeed-Tawfik

Copy link
Copy Markdown

Great contribution! I reviewed the changes and the approach looks clear. I especially like the way you handled the implementation. One suggestion would be to consider adding more comments/documentation around the main logic to make it easier for future contributors to understand. Overall, nice work!

@Foundsheep

Copy link
Copy Markdown
Author

@FidelusAleksander Hi, sorry for tagging you. Please assign this to anyone you know. Anway, can someone check this PR? I think this is quite a simple one and can be merged quickly.

I think this one is drawing too much attention unnecessarily now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

5 participants