Skip to content

The database relation fields support copying existing relations #15876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

The database relation fields support copying existing relations #15876

merged 1 commit into from
Sep 18, 2025
+74 −2

Conversation

Achuan-2
Copy link
Member

@Achuan-2 Achuan-2 commented Sep 18, 2025 •
edited by 88250
Loading

关联列支持一键复制现有关联，方便插入笔记

关联：#15677

  • 点击复制按钮可以一键复制所有关联条目的块引用
PixPin_2025-09-18_11-44-00

@github-actions github-actions bot changed the base branch from master to dev September 18, 2025 03:44
@github-actions GitHub Actions
Copy link

Your PR was set to target master, PRs should be target dev
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@Vanessa219 Vanessa219 merged commit f747739 into siyuan-note:dev Sep 18, 2025
2 checks passed
@Vanessa219 Vanessa219 added this to the 3.3.3 milestone Sep 18, 2025
@88250 88250 changed the title 关联列支持一键复制现有关联，方便插入笔记 Relation fields support copying existing relations Sep 18, 2025
Vanessa219 added a commit that referenced this pull request Sep 18, 2025
@Vanessa219
🎨 #15876
7cc61ba
@Vanessa219 Vanessa219 self-requested a review September 18, 2025 15:57
@TCOTC
Copy link
Contributor

TCOTC commented Sep 19, 2025 •
edited
Loading

@Vanessa219

  • 这里应该是减号而不是星号：

    image

  • 这里不应该这样换行：（.fn__ellipsis 的 display: block; 样式造成的）

    image

  • 输入框需要随菜单一起变宽

    image

  • 以后还是不要把文案拼接在一起，中文和英文还好，但在其他语种的语序语法是错的：

    image

@Achuan-2
Copy link
Member Author

Achuan-2 commented Sep 19, 2025 •
edited
Loading

我之前的设计是没有关联条目就不显示“已关联条目”和复制按钮，有关联条目才显示“已关联条目”和复制按钮
现在在输入框里加一个复制按钮，怪怪的

@TCOTC
Copy link
Contributor

TCOTC commented Sep 19, 2025

一般来说关联字段肯定是用来关联条目的，这个不算问题

@Achuan-2
Copy link
Member Author

一般来说关联字段肯定是用来关联条目的，这个不算问题

复制按钮在输入框里，会让人以为是复制输入框里的文字的

@TCOTC
Copy link
Contributor

TCOTC commented Sep 19, 2025 •
edited
Loading

在桌面端不会有误解，不过在移动端就有点可能。

这个方案在桌面端还是比单独加一行放按钮好多了，移动端以后再另改交互。

@88250 88250 changed the title Relation fields support copying existing relations The database relation fields support copying existing relations Sep 19, 2025
@Vanessa219
Copy link
Member

  1. 其他地方用的也是 * ，这个应该没有问题吧？
  2. 这个地方有点多，后面统一修改吧。

@TCOTC
Copy link
Contributor

TCOTC commented Sep 20, 2025 •
edited
Loading

  1. 其他地方有用到 * 的都需要改 copyTextByType change bullet point from '*' to '-' #15874
  2. 文案问题我单独建个 issue？
  3. 菜单样式的问题要修改

Vanessa219 added a commit that referenced this pull request Sep 20, 2025
@Vanessa219
🎨 #15876
f34d802
@Vanessa219
Copy link
Member

  1. 那统一修改
  2. 直接 PR
  3. 已提交

@Vanessa219 Vanessa219 mentioned this pull request Sep 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@Vanessa219 Vanessa219

@Achuan-2 Achuan-2

Labels
Enhancement
Projects
None yet
Milestone
3.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Achuan-2 @TCOTC @Vanessa219