Feature/gulp5 migration

[Misplon]

Paired with siteorigin/plugin-build#52.

Update build configuration for Gulp 5 compatibility

Changes:

• Updated build-config.js with Font Awesome configuration (version 6.7.2, CSS/fonts paths)
• Updated build/ submodule to point to Gulp 5 implementation

Impact:

• Enables Font Awesome update task functionality
• Points to modernized build system in plugin-build repo

The actual Gulp 5 migration work was done in the plugin-build repository. This PR simply updates the configuration to work with the new build system.

[AlexGStapleton]

I'm getting a build error:

• Using Node 24.7.0..
• Manually deleted node_modules to ensure a hard reset.
• Ran npm install in the build directory.
• Ran npm run build:release --release=1.2.3 (listed here)

This results in:

PS C:\Users\alex\fork\so-widgets-bundle\build> npm run build:release --release=1.2.3

> plugin-build@0.6.0 build:release
> cross-env gulp buildRelease --release=$npm_config_release

TypeError [ERR_INVALID_ARG_TYPE]: The "original" argument must be of type function. Received an instance of Object
    at Object.promisify (node:internal/util:399:3)
    at Object.<anonymous> (C:\Users\alex\fork\so-widgets-bundle\build\node_modules\wp-pot\node_modules\matched\lib\promise.js:5:19)
    at Module._compile (node:internal/modules/cjs/loader:1467:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1551:10)
    at Module.load (node:internal/modules/cjs/loader:1282:32)
    at Module._load (node:internal/modules/cjs/loader:1098:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:215:24)
    at Module.require (node:internal/modules/cjs/loader:1304:12)
    at require (node:internal/modules/helpers:123:16)
    at Object.<anonymous> (C:\Users\alex\fork\so-widgets-bundle\build\node_modules\wp-pot\node_modules\matched\lib\async.js:3:14)
    at Module._compile (node:internal/modules/cjs/loader:1467:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1551:10)
    at Module.load (node:internal/modules/cjs/loader:1282:32)
    at Module._load (node:internal/modules/cjs/loader:1098:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14) {
  code: 'ERR_INVALID_ARG_TYPE'
}

[Misplon]

@AlexGStapleton I've identified and fixed the root cause of your Node.js 24.7.0 build error!

The Issue

The error occurs because wp-pot (used by gulp-wp-pot) depends on matched@3.0.1, which has a util.promisify compatibility issue with Node.js 24. The error you're seeing:

TypeError [ERR_INVALID_ARG_TYPE]: The "original" argument must be of type function. Received an instance of Object

This happens because the older matched version tries to promisify something that's not a function on Node.js 24.

The Fix

I've created PR #1 in the wp-pot fork that updates:

• matched from ^3.0.1 to ^5.0.1 (Node.js 24 compatible)
• Minimum Node.js requirement from >=8 to >=12

All tests pass with the update.

Testing

I reproduced your exact setup (Node.js 24.7.0) and confirmed:

• ✅ The build works fine on macOS with Node 24.7.0
• ✅ The updated wp-pot loads correctly on Node.js 24
• ✅ All existing functionality preserved

Next Steps

Once the wp-pot fix is merged, your Windows + Node.js 24.7.0 build should work without issues. In the meantime, you can:

1. Use Node.js 20 LTS as a temporary workaround
2. Clean install dependencies: rm -rf node_modules package-lock.json && npm install

The OS difference (Windows vs macOS) likely affects how npm resolves the dependency conflict, which is why it works for me but fails for you on the same Node version.

🤖 Generated with Claude Code

[AlexGStapleton]

That worked. The Node version switch didn't help. Only the updated pot change did.

Some issues:

• The built archive has the wrong name for me: so-widgets-bundle.%npm_config_release%.zip
• The version string in so-widgets-bundle.php is also incorrect: Version: %npm_config_release%
• Google Fonts JSON file is downloaded, but it's not being processed. Fonts are stored in a PHP array format in base/inc/fonts.php
• I haven't validated Font Awesome due to the version lock (and the newer version likely breaking compatibility anyway).
• There's some weird spacing being added to base/inc/installer/siteorigin-installer.php after the Class declaration. This specific change should be okay (as it's just spacing), but it's entirely possible other unexpected changes may have occurred.

[Misplon]

Thanks. Are we not getting the same result? Here is mine:
so-widgets-bundle.1.2.3.zip

[Misplon]

Sounds like something environment specific. I'll troubleshoot and have an update later today. Thanks!

[Misplon]

Thanks. Please, try re-testing. I'm working in the blind on most of the reported issues.

[AlexGStapleton]

The reported Google Fonts issue is now resolved.
These issues remain for me:

- Archive name showing %npm_config_release% instead of actual version
- Version string in so-widgets-bundle.php showing %npm_config_release%
- Extra spacing being added to installer PHP files during build

This line will always return %npm_config_release% for me.
Try using process.env.npm_config_release as a fallback if the version string isn't valid.

[Misplon]

Thanks. I'm still working in the blind without the ability to recreate the above issues. Please, could you try re-testing and let me know where we stand now.

[AlexGStapleton]

That last change resolved the versioning issues. This issue is the only issue remaining for me:

• Extra spacing being added to installer PHP files during build

Is that happening for you? There's a screenshot of this in my previous comment.

[Misplon]

I’ll check shortly. None of the issues you’ve reported have been happening on my end. Thanks.

…

On Wed, 17 Sep 2025 at 15:17, Alex S ***@***.***> wrote: *AlexGStapleton* left a comment (siteorigin/so-widgets-bundle#2248) <#2248 (comment)> That last change resolved the versioning issues. This issue is the only issue remaining for me: - Extra spacing being added to installer PHP files during build Is that happening for you? There's a screenshot of this in my previous comment <#2248 (comment)> . — Reply to this email directly, view it on GitHub <#2248 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGAVJ6KZ574B5Z2XI5IXRD3TFUO7AVCNFSM6AAAAACFZSY5HSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBTGIZDSNZVGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Misplon]

Thanks; please try now. It might be best to get directly involved if the issue isn't resolved as I'm working in the blind.

[AlexGStapleton]

That worked. No other issues.