Add audio raw RTP file playback capability #1993
Conversation
There was a problem hiding this comment.
Ok. A few comments for you to consider. But I can merge this as is if you prefer.
I do wonder though if this couldn't have been achieved through some other means, for example by telling ffmpeg (libav...) that it is in fact opening a raw file. It does support both raw µ and A law input files, and for codecs that require framing (Opus...) it will need some more sophisticated processing anyway.
daemon/media_player.c
Outdated
| @@ -1104,6 +1104,57 @@ static int media_player_find_file_begin(struct media_player *mp) { | |||
| static bool media_player_read_packet(struct media_player *mp) { | |||
| if (!mp->coder.fmtctx) | |||
| return true; | |||
| // Handle raw RTP file playback | |||
| if (mp->coder.audio_raw_rtp_mode) { | |||
There was a problem hiding this comment.
Since media_player_read_packet is already used as run_func function pointer, this whole block would lend itself to also be its own function and then be used as run_func, to avoid the if/else
daemon/media_player.c
Outdated
| // Set codec parameters based on input | ||
| if (opts.audio_raw_rtp_codec.len == 4 && strncasecmp(opts.audio_raw_rtp_codec.s, "PCMU", 4) == 0) { | ||
| mp->coder.audio_raw_rtp_codec = AV_CODEC_ID_PCM_MULAW; | ||
| mp->coder.audio_raw_rtp_frame_size = 160; // 20ms frames |
There was a problem hiding this comment.
Maybe make this dependent on the ptime?
daemon/media_player.c
Outdated
| long file_size = ftell(f); | ||
| fseek(f, 0, SEEK_SET); | ||
| // Read entire file into memory | ||
| char *file_data = malloc(file_size); |
There was a problem hiding this comment.
We tend to use g_malloc and g_free in the code.
Also glib provides a convenient g_file_get_contents() helper to do just this.
daemon/media_player.c
Outdated
|
|
||
| // Simulate packet timing (20ms per frame) | ||
| mp->coder.pkt->pts = mp->last_frame_ts; | ||
| mp->coder.pkt->duration = 160; |
There was a problem hiding this comment.
This should probably depend on either ptime or the frame size variable?
daemon/media_player.c
Outdated
| fclose(f); | ||
|
|
||
| // Store in player context | ||
| mp->coder.audio_raw_rtp_data.s = file_data; |
There was a problem hiding this comment.
Actually I think this is never freed? So that definitely needs to be fixed
Fr-Soltanzadeh
force-pushed
the
Feature/1-play-audio-raw-rtp-file
branch
from
7d80f05 to
31e3c03
Compare
|
Thank you for the feedback. As you mentioned, I used ffmpeg functions to open raw rtp file. |
|
Very nice, thank you 👍 Question though, doesn't this now still go through the read -> decode -> encode -> send process? If the purpose is to improve performance then I suppose the decode/encode steps should be skipped and it should go directly from read to send?
Probably something similar to what Just a hint anyway, I can merge it as it is if you prefer. Please do add the new options to the documentation though 😁 |
|
Thank you for the feedback. You're absolutely right - the current implementation still goes through decode/encode, which defeats the performance purpose. I'll revise it to use a passthrough handler instead. |
Hi,
This PR adds the capability to play audio directly from raw RTP payload file to improve performance .
New Command Parameters
The existing play_media NG command is extended with two new parameters:
audio-raw_rtp_file: Path to the file containing raw RTP payloads (no headers).
audio-raw_rtp_codec: Codec of the payloads (e.g., PCMU, PCMA).
Example Usage:
bash
curl -X POST http://localhost:2225/ng-plain -H "Content-Type: application/json" -d '{
"command": "play media",
"audio-raw-rtp-file": "/path/to/file.raw",
"audio-raw-rtp-codec":"PCMU",
"call-id": "123abc",
"from-tag": "456def"
}'
Codec Support: Initially supports G.711 PCMU and PCMA
All existing functionality remains unchanged. The implementation includes proper error handling and memory management.