feat: add UI controls for missing config fields#2011
Open
KristjanKruusRIA wants to merge 6 commits intosipeed:mainfrom
Open
feat: add UI controls for missing config fields#2011KristjanKruusRIA wants to merge 6 commits intosipeed:mainfrom
KristjanKruusRIA wants to merge 6 commits intosipeed:mainfrom
Conversation
- Add steering mode, temperature, max media size, allow read outside workspace to Agent Defaults section - Add Sub-Turns section (max depth, concurrency, timeouts, token budget) - Add Smart Routing section (enabled toggle, light model, threshold) - Add Tool Security section (filter sensitive data, min content length) - Add voice echo transcription and gateway log level to Runtime section - Add parseFloatField utility for float validation - Add English and Chinese translations for all new controls
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing configuration controls to the web config page so users don’t need to edit raw JSON for Sub-Turns, Smart Routing, Tool Security, and several Agent/Runtime defaults.
Changes:
- Extends the config form model with new fields/options and adds parsing helpers for float inputs.
- Adds new config sections (Sub-Turns, Smart Routing, Tool Security) and extends existing sections (Agent Defaults, Runtime) with new controls.
- Adds EN/ZH i18n keys for all new labels/hints and new section titles.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| web/frontend/src/components/config/form-model.ts | Adds new form fields + option lists + parseFloatField utility for new numeric controls. |
| web/frontend/src/components/config/config-sections.tsx | Introduces new UI sections and new controls in Agent Defaults/Runtime. |
| web/frontend/src/components/config/config-page.tsx | Adds save/patch logic (parsing + PATCH payload) and renders the new sections. |
| web/frontend/src/i18n/locales/en.json | Adds translations for new controls and section names. |
| web/frontend/src/i18n/locales/zh.json | Adds translations for new controls and section names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix subturn_max_depth_hint: clarify that 0 uses default (3), not disable - Fix subturn_default_timeout_hint: clarify that 0 uses system default (5 min) - Add fatal log level option to i18n translations (en + zh) - Extract select .find() lookups to component-level variables - Add validation: routing enabled requires non-empty light_model - Only parse filterMinLength when filter_sensitive_data is enabled
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Update routing_threshold_hint (en/zh) to note that values <= 0 use the system default (0.35)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add web UI controls for 17 configuration fields that were previously only editable via raw JSON. This includes Sub-Turn settings, Smart Routing, Tool Security, and several Agent Defaults and Runtime options that had no corresponding UI triggers on the configuration page.
New sections added:
Existing sections extended:
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
N/A — discovered while auditing config.json vs the web UI for missing field coverage.
📚 Technical Context (Skip for Docs)
ConfigSectionCard/Field/SwitchCardFieldcomponent patterns.🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
Frontend-only changes across 5 files:
web/frontend/src/components/config/form-model.ts— 17 new form fields,parseFloatFieldutility,STEERING_MODE_OPTIONSandLOG_LEVEL_OPTIONSconstantsweb/frontend/src/components/config/config-sections.tsx— 3 new sections (SubTurnSection, RoutingSection, ToolSecuritySection), 2 extended sectionsweb/frontend/src/components/config/config-page.tsx— save/parse logic for all new fields, section rendering, routing validation (light_model required when enabled)web/frontend/src/i18n/locales/en.json— 45+ English translation keysweb/frontend/src/i18n/locales/zh.json— 45+ Chinese translation keys☑️ Checklist