fix(agent) scope steering#1844
Merged
yinwm merged 3 commits intosipeed:refactor/agentfrom Mar 22, 2026
Merged
Conversation
yinwm
approved these changes
Mar 22, 2026
Collaborator
yinwm
left a comment
There was a problem hiding this comment.
LGTM!
Review Summary:
- ✅ Scoped steering isolation - clean design for preventing cross-conversation leakage
- ✅ Backwards compatible with fallback queue (
__manual__scope) - ✅ Comprehensive test coverage (scope isolation, direct response polling, multimodal support)
- ✅ Documentation updated alongside code changes
- ✅ Concurrency-safe (proper mutex usage in steeringQueue)
No blocking issues found. Ready to merge.
This was referenced Mar 22, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces Scoped Steering, moving away from a single global steering queue to a session-isolated architecture. It ensures that messages arriving during an active agent turn are only injected if they belong to the same session scope, preventing cross-conversation message leakage. Additionally, this update adds support for multimodal steering (media/images) and improves the agent loop reliability by adding new polling points to catch late-arriving messages.
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
Fixes #
📚 Technical Context (Skip for Docs)
activeScope.Mediarefs in steering messages, ensuring images are resolved via the media pipeline before being sent to the LLM.🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
TestAgentLoop_Steering_DirectResponseContinuesWithQueuedMessagepasses.TestAgentLoop_Continue_PreservesSteeringMediafor multimodal support.TestDrainBusToSteering_RequeuesDifferentScopeMessage.☑️ Checklist