fix(cron): publish deliver=false agent replies#1699
Closed
Alix-007 wants to merge 1 commit intosipeed:mainfrom
Closed
fix(cron): publish deliver=false agent replies#1699Alix-007 wants to merge 1 commit intosipeed:mainfrom
Alix-007 wants to merge 1 commit intosipeed:mainfrom
Conversation
Contributor
Author
|
Closing this to reduce duplicate review load in the crowded cron-response lane. The linked issue #1058 already has multiple open carriers (#1060, #1839), and this branch has stayed unreviewed without becoming the clear maintainer-preferred path. If this exact narrow fix is needed later, it should come back from a fresh clean base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a cron job runs with
deliver=false, PicoClaw bypasses the normal inbound loop andProcessDirectWithChannelreturns the final agent text directly. The old path discarded that return value, so the user never saw the reply.This change publishes the returned agent text to the outbound message bus when it is non-empty, while keeping blank/whitespace-only responses silent.
Type of Change
AI Code Generation
Related Issue
Fixes #1058
Technical Context
ProcessDirectWithChannelreturn value fordeliver=falsecron jobsExecuteJobregression coverage for both behaviorsTest Environment
Evidence
go test ./pkg/tools -run 'TestCronTool_'go test ./pkg/tools -run 'TestCron'go test ./cmd/picoclaw/internal/cronChecklist