Skip to content

Conversation

MehmetYararVX
Copy link
Contributor

@MehmetYararVX MehmetYararVX commented Mar 18, 2025

Ref: UIEN-6724, UIEN-7322

Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 67c269a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
import-map-overrides Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MehmetYararVX
Copy link
Contributor Author

#123 (comment)

tests need to be added to verify that import-map-overrides-server.js is still functioning

@jolyndenning, I added unit tests for the server-api. Would that satisfy the requirements for tests?

@mellis481
Copy link

@jolyndenning Can we get this PR merged please? This is a production security vulnerability that I think a lot of people would like to get resolved.

Copy link
Member

@jolyndenning jolyndenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NodeJS 18 requirement and change in return type for the parse function is breaking

@jolyndenning jolyndenning merged commit f503162 into single-spa:main Mar 31, 2025
2 checks passed
@jolyndenning
Copy link
Member

Released in https://github.com/single-spa/import-map-overrides/releases/tag/v6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants