Skip to content

Conversation

addersuk
Copy link
Member

This pull request updates the gem publishing workflow and project configuration to streamline the release process, improve permissions management, and update project metadata. The main changes are in the GitHub Actions workflow, the gemspec, and the Rakefile.

Workflow and Release Process Improvements

  • Moved job-specific permissions into each job in .github/workflows/gem-publish.yml, granting contents: read to the test job and contents: write/id-token: write to the build job for better security and clarity. [1] [2]
  • Replaced manual RubyGems publishing steps with the standardized rubygems/release-gem@v1 action, simplifying and standardizing the gem release process.
  • Updated Ruby version setup in the workflow to use the .ruby-version file, ensuring consistency with local development environments.

Project Configuration Updates

  • Added require 'bundler/gem_tasks' and set the default rake task to :test in Rakefile, improving developer experience and build consistency.
  • Changed the gem license from a custom copyright to MIT and updated the contact email to a more appropriate address in twiglet.gemspec, ensuring proper open source compliance and communication. [1] [2]

@addersuk addersuk requested a review from a team as a code owner September 30, 2025 07:08
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 07:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the gem publishing workflow and updates project configuration to adopt trusted publishing and improve maintainability. The changes streamline the release process by leveraging GitHub's OIDC token authentication and standardized publishing actions.

  • Implements trusted publishing using rubygems/release-gem@v1 action instead of manual gem build/push steps
  • Updates project metadata to use MIT license and appropriate contact email for open source compliance
  • Enhances developer experience with improved Rakefile configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/gem-publish.yml Migrates to trusted publishing with job-specific permissions and standardized release action
twiglet.gemspec Updates license to MIT and changes contact email to open source specific address
Rakefile Adds bundler gem tasks and sets default task to test for better developer workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@addersuk addersuk merged commit fbdd723 into master Sep 30, 2025
8 of 9 checks passed
@addersuk addersuk deleted the trusted-publishing branch September 30, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants