smp server: refactor subscriptions and delivery in order to always response SOK on subscription with an optional message to follow. #1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
commented
Jun 17, 2025
epoberezkin
commented
Jun 17, 2025
epoberezkin
commented
Jun 17, 2025
| @@ -1957,21 +1974,6 @@ client | |||
| VRVerified q -> Right (q, t'') | |||
| VRFailed e -> Left (corrId', entId', ERR e) | |||
|
|
|||
| deliverMessage :: T.Text -> QueueRec -> RecipientId -> Sub -> Maybe Message -> IO (Transmission BrokerMsg) | |||
There was a problem hiding this comment.
this function unnecessarily duplicates the check for ProhibitSub at call sites and prevents different usage of messages in SUB and in ACK commands.
epoberezkin
commented
Jun 17, 2025
| -- queue is usually deleted by the same client that is currently subscribed, | ||
| -- we delete subscription here, so the client with no subscriptions can be disconnected. | ||
| sub <- atomically $ TM.lookupDelete entId $ subscriptions clnt | ||
| liftIO $ mapM_ cancelSub sub |
There was a problem hiding this comment.
the lack of cancel was potentially a memory leak
epoberezkin
force-pushed
the
ep/refactor-subs
branch
from
47cc842 to
4ea1152
Compare
epoberezkin
changed the title
epoberezkin
force-pushed
the
ep/refactor-subs
branch
from
aef50e9 to
0c1ba54
Compare
epoberezkin
force-pushed
the
ep/refactor-subs
branch
from
894f159 to
f45f5a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.