Pass Socket.IO instance instead of the http server#112
Open
sanrodari wants to merge 3 commits intosimplewebrtc:masterfrom
Open
Pass Socket.IO instance instead of the http server#112sanrodari wants to merge 3 commits intosimplewebrtc:masterfrom
sanrodari wants to merge 3 commits intosimplewebrtc:masterfrom
Conversation
It should not hardcoded the Socket.IO instance creation, and if it's passing the http server instance just for that, instead it should be passsed the io instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should not be hardcoded the Socket.IO instance creation, and if it's passing the http server instance just for that, instead it should be passed the io instance