Move logic to request ice servers into factory class#108
Open
noeplease wants to merge 2 commits intosimplewebrtc:masterfrom
Open
Move logic to request ice servers into factory class#108noeplease wants to merge 2 commits intosimplewebrtc:masterfrom
noeplease wants to merge 2 commits intosimplewebrtc:masterfrom
Conversation
Author
|
I would like to mentioned the reason for the pull request is to seamlessly apply/incorporate Xirsys as a source for turn and stun servers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to remove the functionality use retrieve a local list of ice servers and replace the logic with factory class to allow one to retrieve a list of ice servers from any service.