fix: recover from invalid cache directory (#70)#82
Merged
Conversation
If a prior clone of the gitignore boilerplate repo was interrupted, the cache directory was left behind without a valid git repo inside, causing subsequent gibo invocations to fail. Now detect this state and re-clone. Also propagate the cloneIfNeeded error from Update. Fixes #70
Gate the recovery path to git.ErrRepositoryNotExists so that transient I/O or permission errors don't cause a valid cache to be wiped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70. If a prior clone of the gitignore boilerplate repo was interrupted (e.g. network drop), the cache directory was left behind without a valid git repo inside, so subsequent
giboinvocations failed with "repository does not exist" and had no way to recover short of manually deleting the cache.cloneIfNeedednow verifies the cache dir is a valid git repo viagit.PlainOpen, and re-clones if not.Updatealso now propagates thecloneIfNeedederror instead of discarding it.Test plan
go test ./...gibo updateandgibo dump Pythonboth now recover