[codex] Sync Docker Go version with go.mod#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a dependency-update failure mode where
runny update-depscan raise the Go version ingo.modbut leave the Docker build pinned to an oldergolang:<version>-alpineimage, causingdocker buildto fail before the binary is built. The root cause is that the supported Go version was effectively defined in two places, withgo.modmoving automatically during dependency updates andDockerfileremaining a separate manual edit.The fix adds
tools/sync-go-version.shto derive the Docker builder image from thegodirective ingo.mod, wires that script intorunny update-deps, and adds an explicit--checkguard so both Docker CI and the release Docker workflow fail fast if the files drift out of sync. I validated the change by running./tools/sync-go-version.sh --check, simulating a mismatched Docker base image to confirm the guard fails with a targeted error, and runningdocker build -t gibo:test .successfully.