-
Notifications
You must be signed in to change notification settings - Fork 16
Cosmopower update #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ggalloni
wants to merge
11
commits into
master
Choose a base branch
from
cosmopower_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cosmopower update #234
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3babad1
Pull `cosmopower` from Hidde's fork
ggalloni c98266d
Pull `pyccl` from git to avoid numpy 1.x deps
ggalloni 5fcd2d8
Drop `mflike` caps
ggalloni e5b9ae9
Drop `sphinx` caps
ggalloni e7baa85
Force tensorflow and numpy against inherited deps
ggalloni 84076a3
Add py3.14 support
ggalloni 0cc0f6c
Update uv.lock
ggalloni ac18124
Update testing.yml
ggalloni 28b6c48
Fixes for numpy 2
ggalloni 3251236
Fixes for new `cosmopower` API
ggalloni 6921691
Skip test_crosscov on windows for upstream issue
ggalloni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ authors = [ | |
| ] | ||
| description = "Likelihood and Theory codes for the Simons Observatory." | ||
| readme = "README.rst" | ||
| requires-python = ">3.9,<3.14" # 3.14 is conflicting with many dependencies | ||
| requires-python = ">3.9,<3.15" | ||
| license = { text = "MIT" } | ||
|
|
||
| dependencies = [ | ||
|
|
@@ -27,24 +27,22 @@ Documentation = "https://soliket.readthedocs.io/en/latest/" | |
|
|
||
| [project.optional-dependencies] | ||
| emulator = [ | ||
| "cosmopower (>=0.2.0); python_version < '3.12' and sys_platform != 'win32'", # from tensorflow | ||
| "tensorflow-probability (>=0.20.1); python_version < '3.12' and sys_platform != 'win32'", # breaking change | ||
| "tensorflow (>=2.12); python_version < '3.12' and sys_platform != 'win32'", # from python compatibility | ||
| "cosmopower @ git+https://github.com/HTJense/cosmopower.git@main ; python_version < '3.14' and sys_platform != 'win32'", # from tensorflow | ||
| "tf-keras; python_version < '3.14' and sys_platform != 'win32'", # needed by tensorflow-probability>=0.25 | ||
| ] | ||
| pyccl = [ | ||
| "pyccl>=3.1.2 ; sys_platform != 'win32' and python_version < '3.13'", # for stability | ||
| "pyccl @ git+https://github.com/LSSTDESC/CCL.git@master ; sys_platform != 'win32' and python_version < '3.13'", | ||
| ] | ||
| pyhalomodel = [ | ||
| "pyhalomodel (>=1.0.1); python_version < '3.13'", # from python compatibility | ||
| ] | ||
| mflike = [ | ||
| "mflike (>=1.0.1); python_version < '3.13'", # breaking change | ||
| "fgspectra (>=1.3.0); python_version < '3.13'", # from mflike | ||
| "syslibrary (>=0.2.0); python_version < '3.13'", # from mflike | ||
| "mflike (>=1.0.1)", # breaking change | ||
| "fgspectra (>=1.3.0)", # from mflike | ||
| "syslibrary (>=0.2.0)", # from mflike | ||
| ] | ||
| docs = [ | ||
| "sphinx (<9); python_version < '3.12'", # tensorflow 2.13 pins typing-extensions==4.5.0 | ||
| "sphinx; python_version >= '3.12'", | ||
| "sphinx", | ||
| "sphinx-rtd-theme", | ||
| ] | ||
| dev = [ | ||
|
|
@@ -68,6 +66,9 @@ jupyter = [ | |
| requires = ["hatchling", "hatch-vcs"] | ||
| build-backend = "hatchling.build" | ||
|
|
||
| [tool.hatch.metadata] | ||
| allow-direct-references = true | ||
|
|
||
| [tool.hatch.version] | ||
| source = "vcs" | ||
|
|
||
|
|
@@ -106,6 +107,13 @@ line-ending = "auto" | |
| exclude = [".tox", "build", "cobaya_packages", "test", ".eggs"] | ||
| line-length = 90 | ||
|
|
||
| [tool.uv] | ||
| override-dependencies = [ | ||
| "tensorflow>=2.18", | ||
| "tensorflow-probability>=0.24", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can @HTJense update these dependencies directly in https://github.com/HTJense/cosmopower/blob/main/requirements.txt too?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| "numpy>=1.24.1", | ||
| ] | ||
|
|
||
| [tool.coverage.run] | ||
| omit = ["tests/*", "*/tests/*"] | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be aware that we would no longer be able to deploy to pypi because of taking dependencies from git.
In person we discussed with @anicola that it is unlikely the pyccl pip package will continue to be maintained, but the conda one will.
I guess we could cheat the system a little by keeping these requirements out of our pyproject.toml but including them in the uv env(?). But of course then it would be very easy for a user to acquire a non-functioning installation via pip. If such a naive user exists(?)...