-
Notifications
You must be signed in to change notification settings - Fork 39
add basic building and testing scripts #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@enoodle @moolitayer PTAL |
| pwd | ||
| ) | ||
|
|
||
| readonly II_GO_PACKAGE=github.com/simon3z/image-inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that there is a parent repo for this in openshift. I'll change the package paths to match.
@simon3z would you prefer that I submit PRs there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, it looks like your repo is upstream for openshift? Just let me know if this is wrong. Basically this script is expecting to find the path structure to look like whatever that upstream is just like we require in OpenShift
|
@pweil- I suppose you took this from some other project. Is there any chance that you can slim it down to the minimum required to run the tests on travis? (the rest we will add incrementally, e.g. I wouldn't want any notification to go the openshift irc channel at the moment, etc.). Also you can move this PR to the https://github.com/openshift/image-inspector repository. We'll start to work there. |
|
@simon3z - yep, no problem. I'll take a look at it again next week and see what the bare minimum for running the tests is. |
|
@enoodle please do |
f51bd4b to
4282a9e
Compare
Fixes: #5
@simon3z - not an expert at travis here so please tell me if there is a better way to do this or something is missing.
Adds basic building, gofmt verification, and testing scripts as well as a travis config file. I shamelessly stole most of this from the origin repo but tried to whittle it down to just what would be useful.