Skip to content

Conversation

@pweil-
Copy link

@pweil- pweil- commented Apr 6, 2016

Fixes: #5

@simon3z - not an expert at travis here so please tell me if there is a better way to do this or something is missing.

Adds basic building, gofmt verification, and testing scripts as well as a travis config file. I shamelessly stole most of this from the origin repo but tried to whittle it down to just what would be useful.

[pweil@localhost image-inspector]$ make clean verify test-unit
rm -rf _output Godeps/_workspace/pkg
hack/build-go.sh
hack/build-go.sh took 3 seconds
hack/verify-gofmt.sh
GOTEST_FLAGS="" hack/test-go.sh  
=== RUN   TestValidate
--- PASS: TestValidate (0.00s)
PASS
coverage: 6.2% of statements
ok      github.com/simon3z/image-inspector  1.007s
[DEBUG] Exit trap handler got return code 0
hack/test-go.sh succeeded after 8 seconds

[pweil@localhost image-inspector]$ ll _output/local/bin/local/image-inspector 
-rwxr-xr-x. 1 pweil pweil 9287808 Apr  6 12:16 _output/local/bin/local/image-inspector

@pweil-
Copy link
Author

pweil- commented Apr 6, 2016

@enoodle @moolitayer PTAL

pwd
)

readonly II_GO_PACKAGE=github.com/simon3z/image-inspector
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that there is a parent repo for this in openshift. I'll change the package paths to match.

@simon3z would you prefer that I submit PRs there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it looks like your repo is upstream for openshift? Just let me know if this is wrong. Basically this script is expecting to find the path structure to look like whatever that upstream is just like we require in OpenShift

@simon3z
Copy link
Owner

simon3z commented Apr 29, 2016

@pweil- I suppose you took this from some other project. Is there any chance that you can slim it down to the minimum required to run the tests on travis? (the rest we will add incrementally, e.g. I wouldn't want any notification to go the openshift irc channel at the moment, etc.).

Also you can move this PR to the https://github.com/openshift/image-inspector repository. We'll start to work there.

@pweil-
Copy link
Author

pweil- commented Apr 29, 2016

@simon3z - yep, no problem. I'll take a look at it again next week and see what the bare minimum for running the tests is.

@enoodle
Copy link
Contributor

enoodle commented Sep 23, 2016

@pweil- @simon3z we should move this to openshift/image-inspector , its would be really nice to have these

@simon3z
Copy link
Owner

simon3z commented Sep 23, 2016

@enoodle please do

@simon3z simon3z force-pushed the master branch 6 times, most recently from f51bd4b to 4282a9e Compare June 23, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants