Skip to content

Conversation

@beerbohmdo
Copy link
Contributor

@beerbohmdo beerbohmdo commented Nov 20, 2025

Description

The EagerLoadedList currently throws an error when the list is empty and you try to filter it.

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR feels like it's working around a problem that actually lies in getMatches() where the exception is being thrown from. Is there a way to resolve this in that method instead of in each method that calls it?

@beerbohmdo
Copy link
Contributor Author

beerbohmdo commented Nov 28, 2025

The error is thrown in normaliseFilterArgs not in getMatches. And I can't really change that. I could only change the return value of that method. I could just return an empty filter or all fields, but both just feelds wrong. I could return an distinct value like null in that case, but then I would have to change the calling methods also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants