fix: allow blank lines between CSS declarations #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kmuncie last week was the first time I'd done any hands-on CSS dev in any of our repos in a long time. This rule kept tripping me up because there would be conceptually-logical groupings of CSS declarations that it made sense to separate (e.g. separate CSS var defaults, from grid/flex layout declarations, from font and color declarations). But this rule would complain when I put any blank lines between declarations. Having this rule seems to conflict with our principles on blank lines. This PR is an attempt to make the linting match those principles, but there may be more things to ignore, or a better way to structure the rule.
cc @yokuze