Skip to content

Fix dev mode link to 3rd part platform #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Toby-Masters-SF wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix dev mode link to 3rd part platform #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db2ff3d
[Dev-73] Update wording for dev-mode-liquid to make more generic
Toby-Masters-SF Nov 7, 2024
f673eb5
Update references to
Toby-Masters-SF Nov 8, 2024
7b64ac7
Update version no
Toby-Masters-SF Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the "silverfin-development-toolkit" extension will be documented in this file.

## [1.18.4]

- Bump Silverfin CLI version (1.26.15 -> 1.27.1) and update hard-coded links to the SF environment

## [1.18.3]

- Bump Silverfin CLI version (1.26.14 -> 1.26.15)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "silverfin-development-toolkit",
"displayName": "Silverfin Development Toolkit",
"version": "1.18.3",
"version": "1.18.4",
"publisher": "Silverfin",
"icon": "resources/sf-icon.png",
"engines": {
Expand Down
8 changes: 6 additions & 2 deletions src/lib/sidebar/panelFirm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ export default class FirmViewProvider implements vscode.WebviewViewProvider {
); // [[firmId, firmName]...]
const usedInFirmsRows = templateUsedInFirmsData
.map((item: TemplateUsedInFirmData) => {
let templateUrl = `https://live.getsilverfin.com/f/${item.firmId}/${item.templateFolder}/${item.templateId}/edit`;
const baseURL = process.env.SF_HOST || "https://live.getsilverfin.com";
console.log("TEST A");
let templateUrl = `${baseURL}/f/${item.firmId}/${item.templateFolder}/${item.templateId}/edit`;
return /*html*/ `<vscode-data-grid-row grid-columns="2">
<vscode-data-grid-cell grid-column="1">
${item.firmId}
Expand All @@ -97,7 +99,9 @@ export default class FirmViewProvider implements vscode.WebviewViewProvider {
firm[0].toString() === firmId.toString()
? /*html*/ `<vscode-tag>Active</vscode-tag>`
: "";
let firmUrl = `https://live.getsilverfin.com/f/${firm[0]}`;
const baseURL = process.env.SF_HOST || "https://live.getsilverfin.com";
console.log("TEST B");
let firmUrl = `${baseURL}/f/${firm[0]}`;
return /*html*/ `<vscode-data-grid-row>
<vscode-data-grid-cell grid-column="1">
${firm[0]} ${firm[1] ? `(${firm[1]})` : ""}
Expand Down
4 changes: 2 additions & 2 deletions src/lib/sidebar/panelTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ export default class TestsViewProvider implements vscode.WebviewViewProvider {
<vscode-data-grid-cell grid-column="1">
${
this.firmIdStored
? `Push updates to Silverfin in firm ${this.firmIdStored}`
: "You need to add a default firm before you can activate development mode to push automatically to Silverfin"
? `Push updates to Platform in firm ${this.firmIdStored}`
: "You need to add a default firm before you can activate development mode to push automatically to Platform"
} <i>(on save)</i>
</vscode-data-grid-cell>
<vscode-data-grid-cell grid-column="2" class="vs-actions">
Expand Down