Foresee logic to include test firm id in run-test action #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AgustinSilverfin
left a comment
AgustinSilverfin
left a comment
There was a problem hiding this comment.
Can you also look into the outdate versions?
we should use node 20 instead of 18
and other actions v4 instead of v3.
.github/workflows/run_tests.yml
Outdated
| # 1. Template-specific test_firm_id (highest priority) | ||
| AVAILABLE_FIRM_IDS=$(cat ${CURRENT_DIR}/config.json | jq -r ".id | keys[]" 2>/dev/null || echo "") | ||
| if [[ "$AVAILABLE_FIRM_IDS" == *"$TEST_FIRM_ID"* ]]; then |
Contributor
There was a problem hiding this comment.
This may return false positives. If there is available id 1020 and test firm id is 102 it may return it?
Can you double check this? We may need to loop through available in that case and check if it's exactly the same
Collaborator
Author
There was a problem hiding this comment.
Correct, I implemented a loop to go over the id's and doing exact matching.
Collaborator
Author
|
@AgustinSilverfin Can you please do another review? Implemented the new versions and introduced a loop for id-matching. |
AgustinSilverfin
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the changes made
If test firm id is present in the config of a template, that will be the preferred option.
If this is not the case, we can fall back to the repo variable (1 variable that can be set for the entire repo).
If this is not set either, we fall back to the default behaviour.
Fixes # (link to the corresponding issue)
Type of change
Checklist