Cleanup code around dark mode #1542
Conversation
| // otherwise leave it so the client can choose depending on the system | ||
| // settings | ||
| const darkMode = await clientStore.get("darkMode"); | ||
| if (darkMode != null) { |
There was a problem hiding this comment.
The != operator does not exist in my definition of JavaScript, surprised that lint even allows it 😆
There was a problem hiding this comment.
Yeah I wasn't 100% sure what this would/could return here. Because if you follow the definition, some are typed to return null and some return undefined and there are some parts were typescript doesn't check
|
I have not put much thought into this, but I'm not sure we shouldn't deprecate clientStore altogether, since all our stores our now client-side anyway, maybe it should just be replaced with datastore everywhere? clientStore was always a bit weird because of the different key format (strings vs lists of strings). Separate topic, I'm ok to merge this on its own. |
I guess it uses datastore under the hood anyways. I'm not sure how many people use it, I use it in silversearch, just because it's a little easier to use than the datastore api. |
I don't want to offend anybody, but the code in the
useEffecthere, was really not it. This should also fix a bug, where you couldn't force white mode if your system is set to dark mode.And maybe we should also add something to the docs about the use of the
clientStorehere, because this caused confusion multiple times now.