Skip to content

SF-3637 Deduplicate permissions #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

SF-3637 Backend changes

7efc714
Select commit
Loading
Failed to load commit list.
Open

SF-3637 Deduplicate permissions #3566

SF-3637 Backend changes
7efc714
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2025 in 0s

82.89% (-0.01%) compared to 12c8136, passed because coverage increased by 0.01% when compared to adjusted base (82.88%)

View this Pull Request on Codecov

82.89% (-0.01%) compared to 12c8136, passed because coverage increased by 0.01% when compared to adjusted base (82.88%)

Details

Codecov Report

❌ Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.89%. Comparing base (12c8136) to head (7efc714).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/SIL.XForge.Scripture/Services/ParatextService.cs 50.00% 1 Missing and 1 partial ⚠️
...ture/ClientApp/src/app/core/permissions.service.ts 90.00% 1 Missing ⚠️
...SIL.XForge.Scripture/Services/MachineApiService.cs 83.33% 0 Missing and 1 partial ⚠️
.../SIL.XForge.Scripture/Services/SFProjectService.cs 96.55% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3566      +/-   ##
==========================================
- Coverage   82.90%   82.89%   -0.01%     
==========================================
  Files         605      605              
  Lines       36974    36992      +18     
  Branches     6058     6064       +6     
==========================================
+ Hits        30652    30665      +13     
+ Misses       5408     5401       -7     
- Partials      914      926      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov