Skip to content

SF-3479 Show previous completed drafts when opening draft tab #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Jul 31, 2025

This PR updates the behaviour when opening a draft tab. If draft history is enabled, previous drafts will be shown on books and the menu to select historical drafts will be visible. If the draft history is not enabled, the previous behaviour is expected and the page will say that no draft exist for the book.


This change is Reviewable

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.43%. Comparing base (cd97180) to head (f69c9cd).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3343      +/-   ##
==========================================
+ Coverage   82.42%   82.43%   +0.01%     
==========================================
  Files         607      607              
  Lines       35571    35580       +9     
  Branches     5802     5781      -21     
==========================================
+ Hits        29319    29331      +12     
- Misses       5373     5387      +14     
+ Partials      879      862      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Jul 31, 2025
@pmachapman pmachapman self-requested a review August 3, 2025 20:45
@pmachapman pmachapman self-assigned this Aug 3, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Aug 3, 2025
@pmachapman pmachapman force-pushed the fix/sf-3479-view-older-drafts branch from 93bee66 to f15e5a1 Compare August 13, 2025 17:52
@pmachapman pmachapman force-pushed the fix/sf-3479-view-older-drafts branch from f15e5a1 to f69c9cd Compare August 13, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants