SF-3437 Remove the blank: true properties from the texts data model #3339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text-view-model.ts
Fixed
Show fixed
Hide fixed
src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text-view-model.ts
Fixed
Show fixed
Hide fixed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3339 +/- ##
=========================================
Coverage ? 82.38%
=========================================
Files ? 606
Lines ? 35529
Branches ? 5788
=========================================
Hits ? 29271
Misses ? 5404
Partials ? 854 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pmachapman
force-pushed
the
feature/SF-3437-v3
branch
from
bf2b9ba to
86da565
Compare
src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text-view-model.ts
Fixed
Show fixed
Hide fixed
pmachapman
force-pushed
the
feature/SF-3437-v3
branch
5 times, most recently
from
dbd410d to
ce47303
Compare
pmachapman
force-pushed
the
feature/SF-3437-v3
branch
from
ce47303 to
816ab29
Compare
pmachapman
changed the title
pmachapman
force-pushed
the
feature/SF-3437-v3
branch
from
816ab29 to
1bb742a
Compare
pmachapman
added
the
will require testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
blank: trueops from the texts data model to the view model.It also disables editing on older version of the Scripture Forge client, requiring them to update to the latest version before editing resumes.
The frontend can update text docs that either do or do not contain
blank: trueops. This means that there is no need to migrate all text documents, and that restoring older text documents will still work correctly.This change is