SF-3434 Move training file upload into draft sources page

[josephmyers]

This follows the Balsamiq design on SF-3434.

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.52%. Comparing base (e34ce95) to head (c7b0e73).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...eneration/draft-sources/draft-sources.component.ts	92.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   82.52%   82.52%   -0.01%     
==========================================
  Files         605      605              
  Lines       35217    35194      -23     
  Branches     5701     5720      +19     
==========================================
- Hits        29064    29044      -20     
+ Misses       5312     5299      -13     
- Partials      841      851      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Nateowami]

Thanks for your work on this. A couple things I notice (which I think are not new):

1. The color of the upload icon is wrong.
2. The file should not be toggleable. (In this context it's really not obvious what toggling it does).

[josephmyers]

Though I do agree with this direction, a fallout of this is that uploading, and deleting, now circumvents the Save & Sync behavior that the rest of the page follows. In effect, if you upload a file and then Cancel, the file remains and would be used for builds. I can rewrite the upload dialog to postpone the upload until Save & Sync, if that works.

[pmachapman]

I can rewrite the upload dialog to postpone the upload until Save & Sync, if that works.

This is a good idea. If someone uploads or deletes files erroneously, they may cancel out and want it back the way it was. (The offline support for uploading files may help you with this?) Also, can you postpone the deletions to the Save & sync action as well? Thanks!

Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Nateowami)

---

src/SIL.XForge.Scripture/Models/DraftConfig.cs line 9 at r1 (raw file):

{
    [Obsolete("For backwards compatibility with older frontend clients. Deprecated June 2025.")]
    public bool AdditionalTrainingData { get; set; }

You have removed this from the TypeScript model, so it should be removed here too. The C# model and TypeScript model must be in sync with what is in Mongo.

Code quote:

    [Obsolete("For backwards compatibility with older frontend clients. Deprecated June 2025.")]
    public bool AdditionalTrainingData { get; set; }

---

src/RealtimeServer/scriptureforge/models/translate-config.ts line 58 at r1 (raw file):

  additionalTrainingSourceEnabled: boolean;
  additionalTrainingSource?: TranslateSource;
  alternateSourceEnabled: boolean;

You will need a migrator to remove the additionalTrainingData property.

Code quote:

export interface DraftConfig {
  additionalTrainingSourceEnabled: boolean;
  additionalTrainingSource?: TranslateSource;
  alternateSourceEnabled: boolean;

[pmachapman]

Looks good - apologies - just one tiny change I noticed while doing a final review:

Can you please remove additionalTrainingData from the validationSchema in sf-project-service.ts? Thanks!

Reviewed 1 of 5 files at r2, 8 of 8 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

[pmachapman]

Thank you for your work on this!

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

[pmachapman]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)