-
-
Notifications
You must be signed in to change notification settings - Fork 5
Create book/chapter combined chooser component #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2992 +/- ##
=======================================
Coverage 82.70% 82.70%
=======================================
Files 563 563
Lines 32695 32695
Branches 5303 5303
=======================================
Hits 27041 27041
- Misses 4859 4871 +12
+ Partials 795 783 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Neat! A few minor comments/suggestions:
|
a7b5e58
to
22dbe81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions! I implemented them, along with fixing some bugs.
Reviewable status: 0 of 9 files reviewed, all discussions resolved
0c9905a
to
d978e10
Compare
What bugs, I wonder? Might be nice to have them documented here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at the code, but this does work quite well in Storybook, in the limited testing available there. I'm interested to see it integrated. Good job so far!
Reviewable status: 0 of 9 files reviewed, all discussions resolved
This is a draft for feedback for a combined book/chapter chooser similar to the one from Platform.Bible.
This combined chooser should offer faster selection for desktop users via book filtering and faster chapter selection. I'm not sure how the usability compares to the current book/chapter chooser on mobile devices, but one possibility is to continue to offer the current, split dropdown chooser for mobile devices via media query.
You can see it in storybook:
https://644bffe327c540a62f0fd260-uantdiyvlk.chromatic.com/?path=/story/shared-book-chapter-combined-chooser--default
This change is