Fix bug with base NLLB translation #788
Merged
+28
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #778, allowing the base NLLB model to translate with the correct language codes.
src_lang
andtrg_lang
are added as arguments for_create_inference_model
and_configure model
insilnlp.nmt.hugging_face_config.py
to set the language codes properly in_configure_model
. The test language codes are now used instead of the validation language codes, unless a different code is provided using the--trg-iso
or--src-iso
options forsilnlp.nmt.translate.py
This change is